Hello Wolfgang,
Wolfgang Denk wrote:
> In message <4a61c602.10...@denx.de> you wrote:
>> I don;t understand you here. You have a "CONFIG name convention cleanup"
>> patch somewhere? Is this somewhere discussed, how this should
>> look like? (I think, a "CONFIG_DRIVER_I2C_xxx" would be good)
>
> It never has been discussed or even mentioned before.
>
> Jean-Christophe, I recommend you accept Heiko's patch as is (as it was
> submitted before your patch), and then just regenerate your patch
> (which is trivial for you to do as you have the script ready).
Hmm.. I have to fix some comments, which Prafulla suggested, also
to integrate the speed settings ...
So I don;t know, if this patch should go in mainline as it is ...
I think it is easier, if we integrate Jean-Christophes renaming
patch (the reposted version with correct subject ;-)
and then I can easy adapt "my" patch ...
>>>> +static unsigned int i2c_bus_num __attribute__ ((section (".data"))) = 0;
>>>> +#if defined(CONFIG_I2C_MUX)
>>>> +static unsigned int i2c_bus_num_mux __attribute__ ((section ("data"))) =
>>>> 0;
>>> .data
>>>> +#endif
>>> no need of put it in section .data on arm
>> Hmm.. I am not an arm expert ...
>
> I disagree with Jean-Christophe here. Do not change this code.
Ok. If Jean-Christophe accept it ...
bye
Heiko
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
