On Thu, Jul 30, 2015 at 12:13:06PM -0600, Stephen Warren wrote:
> On 07/29/2015 05:02 PM, Simon Glass wrote:
> >Hi Stephen,
> >
> >On 29 July 2015 at 13:48, Stephen Warren <swar...@wwwdotorg.org> wrote:
> >>
> >
> >Commit message?
> 
> I guess I can add one, but there really much useful additional information I
> can give.
> 
> I've also been "guilty" of pushing for commit messages for cases like this,
> but I wonder if we shouldn't just consider the commit subject as part of the
> overall description and hence allow empty commit descriptions when they
> won't add anything?
> 
> Anyway, since I'm likely to spin the patch for e2220-1170.h at least, I can
> add something.

FWIW, here's the commit message from the Linux kernel commit that I've
queued up for P2371:

        arm64: tegra: Add NVIDIA P2371 support

        The NVIDIA P2371 is an internal reference design that uses a P2530
        compute module hooked up to a P2595 base board and an optional display
        module for a 1200x1920 MIPI DSI panel.

and here's the one for P2595:

        arm64: tegra: Add NVIDIA P2595 base board support

        The NVIDIA P2595 base board is used in several reference designs and
        provides the connectors to connect the P2530 compute module to the
        outside world. It features a USB 3.0 network adapter, a USB 3.0 port,
        an HDMI port, a SATA port, an audio codec, a microSD card slot and a
        display connector, among others.

and finally for P2530:

        arm64: tegra: Add NVIDIA P2530 compute module support

        The NVIDIA P2530 is a compute module used in several reference designs.
        It features a Tegra210 SoC, 4 GiB of LPDDR4 RAM, 16 GiB eMMC and various
        other essentials. It is typically connected to some base board that
        provides the connectors needed to hook it up to the outside world.

This doesn't go into a lot of detail, but I think it's nice to give
people some amount of information about what kind of board this is. It
shows the capabilities, which I think is vital if we want people to
actually use Tegra. With this kind of information people may actually
start being interested in the device. If we don't have any information
at all, people are likely going to ignore the board.

Thierry

Attachment: signature.asc
Description: PGP signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to