On Wednesday, July 22, 2015 at 11:15:31 PM, Alonso Adrian wrote: > Hi Marek, > > Comments inline. > > > -----Original Message----- > > From: Marek Vasut [mailto:ma...@denx.de] > > Sent: Monday, July 20, 2015 8:56 PM > > To: Alonso Lazcano Adrian-B38018 > > Cc: u-boot@lists.denx.de; sba...@denx.de; ota...@ossystems.com.br; > > Estevam Fabio-R49496; Li Frank-B20596; Garg Nitin-B37173 > > Subject: Re: [PATCH 02/15][v2] imx: usb: ehci-mx7 add usb driver for > > i.MX7D > > > > On Tuesday, July 21, 2015 at 02:17:06 AM, Adrian Alonso wrote: > > > * Add support for usb driver for i.MX7D SoC > > > > > > Signed-off-by: Adrian Alonso <aalo...@freescale.com> > > > Signed-off-by: Ye.Li <b37...@freescale.com> > > > Signed-off-by: Peng Fan <peng....@freescale.com> > > > > Hi! > > > > Do we really need yet-another-driver for i.MX ? > > [Adrian] USB support for iMX could be re-implemented following DM model, > At the moment ehci-mx7 handles the SoC specific settings for USB support.
But do we really need yet another driver for i.MX ? We already have one for MX23/28, MX5, MX6 and one for Vybrid . > > > --- > > > Changes for V2: Resend > > > > > > drivers/usb/host/Makefile | 1 + > > > drivers/usb/host/ehci-mx7.c | 103 > > > > > > ++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, > > > > 104 > > > > > insertions(+) > > > > > > create mode 100644 drivers/usb/host/ehci-mx7.c > > > > > > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile > > > index 4d35d3e..7267160 100644 > > > --- a/drivers/usb/host/Makefile > > > +++ b/drivers/usb/host/Makefile > > > @@ -36,6 +36,7 @@ obj-$(CONFIG_USB_EHCI_MXC) += ehci-mxc.o > > > > > > obj-$(CONFIG_USB_EHCI_MXS) += ehci-mxs.o > > > obj-$(CONFIG_USB_EHCI_MX5) += ehci-mx5.o > > > obj-$(CONFIG_USB_EHCI_MX6) += ehci-mx6.o > > > > > > +obj-$(CONFIG_USB_EHCI_MX7) += ehci-mx7.o > > > > > > obj-$(CONFIG_USB_EHCI_OMAP) += ehci-omap.o > > > obj-$(CONFIG_USB_EHCI_PPC4XX) += ehci-ppc4xx.o > > > obj-$(CONFIG_USB_EHCI_MARVELL) += ehci-marvell.o diff --git > > > > > > a/drivers/usb/host/ehci-mx7.c b/drivers/usb/host/ehci-mx7.c new file > > > mode 100644 index 0000000..7429d62 > > > --- /dev/null > > > +++ b/drivers/usb/host/ehci-mx7.c > > > @@ -0,0 +1,103 @@ > > > +/* > > > + * Copyright (c) 2009 Daniel Mack <dan...@caiaq.de> > > > + * Copyright (C) 2010-2015 Freescale Semiconductor, Inc. > > > + * > > > + * SPDX-License-Identifier: GPL-2.0+ > > > + */ > > > + > > > +#include <common.h> > > > +#include <usb.h> > > > +#include <errno.h> > > > +#include <linux/compiler.h> > > > +#include <usb/ehci-fsl.h> > > > +#include <asm/io.h> > > > +#include <asm/arch/crm_regs.h> > > > +#include <asm/arch/clock.h> > > > +#include <asm/imx-common/iomux-v3.h> > > > + > > > +#include "ehci.h" > > > + > > > +#define USB_NC_OFFSET 0x200 > > > + > > > +#define UCTRL_PM (1 << 9) /* OTG Power Mask */ > > > +#define UCTRL_OVER_CUR_POL (1 << 8) /* OTG Polarity of Overcurrent > > > > */ > > > > > +#define UCTRL_OVER_CUR_DIS (1 << 7) /* Disable OTG Overcurrent > > > > Detection > > > > > */ + > > > > Are these bits EHCI spiecific or MX7 Chipidea controller specific ? > > [Adrian] They are iMX7 specific OK [...] > > > +} > > > + > > > +int __weak board_ehci_hcd_init(int port) { > > > + return 0; > > > +} > > > + > > > +int __weak board_ehci_power(int port, int on) { > > > + return 0; > > > +} > > > > Can you add kerneldoc style comments to the functions please ? > > [Adrian] All change suggestion to be addressed in a new patch version. Thanks! _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot