Hi Simon, On Thu, Jul 9, 2015 at 4:28 AM, Simon Glass <s...@chromium.org> wrote: > Hi Bin, > > On 8 July 2015 at 07:50, Bin Meng <bmeng...@gmail.com> wrote: >> Remove duplicated entry of OF_CONTROL in crownbay_defconfig and >> minnowmax_defconfig which causes a warning when making defconfig. >> The updated defconfig files are generated by 'make savedefconfig'. >> >> Signed-off-by: Bin Meng <bmeng...@gmail.com> >> --- >> >> configs/crownbay_defconfig | 14 ++++++-------- >> configs/minnowmax_defconfig | 6 ++---- >> 2 files changed, 8 insertions(+), 12 deletions(-) > > I've incorporated this into the offending patches in x86/master. > Please take a look and let me know what you think. I'd rather avoid > strange errors in the tree, even tools/genboardscfg.py. >
It looks good. But the order does not match 'savedefconfig', like what I did in this patch. I've tested all 7 x86 boards, and found only these two have this ordering issue. I am not sure if this issue is now a must as I see the mainline seems all defconfigs are updated. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
