Hi Bin, On 6 July 2015 at 02:12, Bin Meng <bmeng...@gmail.com> wrote: > Hi Tom, > > On Wed, Jul 1, 2015 at 7:17 AM, Simon Glass <s...@chromium.org> wrote: >> Hi Bin, >> >> On 22 June 2015 at 21:45, Bin Meng <bmeng...@gmail.com> wrote: >>> Currently PCI expansion ROM address is assigned by a call to >>> pciauto_setup_rom() outside of the pci auto config process. >>> This does not work when expansion ROM is on a device behind >>> PCI bridge where bridge's memory limit register was already >>> programmed to a value that does not cover the newly assigned >>> expansion ROM address. To fix this, we should configure the >>> ROM address during the auto config process. >> >> Well I should have known that approach would not work :-( >> >>> >>> Signed-off-by: Bin Meng <bmeng...@gmail.com> >>> >>> --- >>> >>> Changes in v2: >>> - Handle header type 1 ROM address programming >>> >>> drivers/pci/pci_auto.c | 48 >>> ++++++++++++++++++++++-------------------------- >>> drivers/pci/pci_rom.c | 5 ----- >>> include/pci.h | 9 --------- >>> 3 files changed, 22 insertions(+), 40 deletions(-) >> >> Reviewed-by: Simon Glass <s...@chromium.org> > > Will you apply these two patches for v2015.07 release, or you want to > leave them to next?
I've already brought in patches to x86/master that I was not planning to send to mainline for this release (no concerns about the patches, just merge window timing). But I could put these into another branch and sent a pull request if you like Bin? My understanding was that this fix did not affect any current boards / functionality, but I may have that wrong. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
