On Mon, 2015-06-22 at 17:39 +0200, Hans de Goede wrote: > How about the following: > > > Subject: [PATCH 1/3] sunxi: musb: Improve output during probing > > When we return an error the usb core will log a message, so in this case > do not print anything. > > Signed-off-by: Hans de Goede <hdego...@redhat.com>
Much better, especially given the below. Acked-by: Ian Campbell <ian.campb...@citrix.com> > > --- a/drivers/usb/musb-new/sunxi.c > +++ b/drivers/usb/musb-new/sunxi.c > @@ -301,21 +301,22 @@ int musb_usb_probe(struct udevice *dev) > { > struct musb_host_data *host = dev_get_priv(dev); > struct usb_bus_priv *priv = dev_get_uclass_priv(dev); > + int ret; Wrong sort of w/space I suspect. [...] > This is exactly what the other host drivers do, only print > something on success, and leave printing errors up to the > caller. If all others do this I think doing this is the best compromise too. Ian. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot