Hi Masahiro-san, On Mon, May 18, 2015 at 8:58 PM, Masahiro Yamada <yamada.masah...@socionext.com> wrote: > Hi Joe, > > 2015-05-16 6:40 GMT+09:00 Joe Hershberger <joe.hershber...@ni.com>: >> This will ensure that the order of the defconfig entries will always >> match that of the Kconfig files. After one slightly painful (but >> still early in the process) pass over all boards, this should keep >> the defconfigs clean from here on. >> >> Users must edit the Kconfig first to add the menu entries and then run >> moveconfig.py to update the defconfig files and the include configs. >> >> As such, moveconfig.py cannot compare against the '.config' contents. >> >> Signed-off-by: Joe Hershberger <joe.hershber...@ni.com> > > > This feature expects the defconfigs are all clean. > Otherwise, savedefconfig would make "git diff" noisier. > > It is safer to use "make menuconfig && make savedefconfig" > for adding new options, but some people still try to > edit the defconfig directly... > > Perhaps, should do the global cleanup periodically?
I agree that until people (both contributors and custodians) get used to this as the best way, we will likely need a few global clean-ups, but I think with the addition of this tool to main-line the instance of this will likely drop sharply. Moving configs is a hassle, so with a tool available I doubt many people will do it manually. That's why it is important that the tool do it the cleanest way. Hopefully for the case where a config is changed on a board, the custodian will notice if it is just added to the bottom of the file. It seems to work out for Linux. Cheers, -Joe _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
