Re: [U-Boot] [PATCH-ARM] Add support for Embest SBC2440-II Board 5/7

[Jean-Christophe PLAGNIOL-VILLARD]

> >> +  /*
> >> +   * mask all IRQs by setting all bits in the INTMR - default
> >> +   */
> >> +  mov     r1, #0xffffffff
> >> +  ldr     r0, =INTMSK
> >> +  str     r1, [r0]
> >> +# if defined(CONFIG_S3C2410) || defined(CONFIG_S3C2440)
> >> +  ldr     r1, =INTSMASK
> >> +  ldr     r0, =INTSUBMSK
> >> +  str     r1, [r0]
> >> +# endif
> >> +
> >> +  /* FCLK:HCLK:PCLK = 1:2:4 */
> >> +  /* default FCLK is 120 MHz ! */
> >> +  ldr     r0, =CLKDIVN
> >> +  mov     r1, #CLKDIVVAL
> >> +  str     r1, [r0]
> >> +
> >> +#ifdef CONFIG_S3C2440
> >> +  /* Set asynchronous bus mode */
> >> +  mrc     p15, 0, r1, c1, c0, 0   /* read ctrl register */
> > whitespace please fix
> >> +  orr     r1, r1, #0xc0000000     /* Asynchronous */
> > whitespace please fix
> >> +  mcr     p15, 0, r1, c1, c0, 0   /* write ctrl register */
> > whitespace please fix
> >> +#endif  /* CONFIG_S3C2440 */
> > whitespace please fix
> 
> I'm not sure what the problem is - should the comments be indented with
> a tab?
no with space here
> 
> By the way, I'm on vacation for the next 2 weeks so I won't be able to
> make the changes before the merge window closes. Do I need to wait until
> v2009.08 is released and re-base my changes to that?
after the merge will be close I'll open the next branch and depending on the
time I may ask to have it for this release to wd
> 
> >> +
> >> +  mov     pc, lr
> >> +
> >> +#endif  /* CONFIG_S3C24X0 */
Best Regards,
J.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot