Hello Prafulla,
> As stated in other email thread too.
> Now all dependencies for Sheevaplug board support are in accepted state
> except this patch http://lists.denx.de/pipermail/u-boot/2009-June/055112.html
I know that but I cannot test it because I do not have the hardware,
so I depend on others here. (it might be even you). I already
mentioned that I would prefer the cleanup patch from Michael
Trimarchi, if it is correct.
At least there is 1 significant difference between your patch and the
patch of Michael
Your patch contains this:
--------------------------------------------------------
- typeReq = req->request << 8 | req->requesttype;
+ typeReq = req->request | req->requesttype << 8;
switch (le16_to_cpu(typeReq)) {
--------------------------------------------------------
and Michael patch contains this:
--------------------------------------------------------
- typeReq = req->request << 8 | req->requesttype;
+ typeReq = req->request | req->requesttype << 8;
- switch (le16_to_cpu(typeReq)) {
+ switch (typeReq) {
--------------------------------------------------------
So, at least one of them is wrong.
This difference is reason enough for me to not pull either patch in
until this is clear.
Kind Regards,
Remy
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
