Hi Tom, Thanks for your inputs. I have cleaned up the board/overo/ code like you suggested. I will send a separate email with the patches requesting for review.
-Arun On Tue, Apr 21, 2015 at 1:16 PM, Tom Rini <tr...@konsulko.com> wrote: > On Tue, Apr 21, 2015 at 01:12:37PM -0700, Ash Charles wrote: > > On Tue, Apr 21, 2015 at 12:23 PM, Tom Rini <tr...@konsulko.com> wrote: > > > Sadly it may make sense to move some SPL-only > > > functions out into a file that is only built/linked for SPL due to this > > > bug. > > Ah---that is a funky bug. > > Is it reasonable to wrap the offending lines in a > > #ifndef CONFIG_SPL_BUILD > > <u-boot code with strings that bloat SPL> > > #endif // CONFIG_SPL_BUILD > > ? > > Would this restrict it to be included only in u-boot (where the code > > is needed) rather than getting unnecessarily pulled into SPL? > > That starts getting pretty messy looking which is why I was thinking of > following the mx6 model of having boardname.c and boardname_spl.c or > just board.c and spl.c > > -- > Tom > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
