On 5 February 2015 at 22:06, Simon Glass <s...@chromium.org> wrote: > At present buildman tries to detect an aborted build and doesn't record a > result in that case. This is to make sure that an abort (e.g. with Ctrl-C) > does not mark the build as done. Without this option, buildman would never > retry the build unless -f/-F are provided. The effect is that aborting the > build creates 'fake errors' on whatever builds buildman happens to be > working on at the time. > > Unfortunately the current test is not reliable and this detection can > trigger if a required toolchain tool is missing. In this case the toolchain > problem is never reported. > > Adjust the logic to continue processing the build result, mark the build as > done (and failed), but with a return code which indicates that it should be > retried. > > The correct fix is to fully and correctly detect an aborted build, quit > buildman immediately and not write any partial build results in this case. > Unfortunately this is currently beyond my powers and is left as an exercise > for the reader (and patches are welcome). > > Signed-off-by: Simon Glass <s...@chromium.org> > --- > > tools/buildman/builderthread.py | 21 ++++++++++++++++----- > 1 file changed, 16 insertions(+), 5 deletions(-)
Applied to u-boot-x86/buildman. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
