Hello Jörg,
Am 14.04.2015 17:32, schrieb Jörg Krause:
Hello Heiko,
On Di, 2015-04-14 at 10:02 +0200, Heiko Schocher wrote:
Hello Jörg,
Am 14.04.2015 08:29, schrieb Jörg Krause:
Hello Heiko,
On Di, 2015-04-14 at 08:12 +0200, Heiko Schocher wrote:
Hello Jörg,
Am 13.04.2015 22:17, schrieb Jörg Krause:
Signed-off-by: Jörg Krause <joerg.krause@embedded.rocks>
---
drivers/mtd/nand/mxs_nand.c | 7 +++++++
1 file changed, 7 insertions(+)
nitpick only ...
I'm unsure what this comment means translated to German. Something
like small changes only?
Yes, something like "pingelig"
Okay, now I understand the translation but not the meaning. Do you
mean that this patch should be squashed into patch 1 for example?
diff --git a/drivers/mtd/nand/mxs_nand.c
b/drivers/mtd/nand/mxs_nand.c
index 912fed8..76e47ab 100644
--- a/drivers/mtd/nand/mxs_nand.c
+++ b/drivers/mtd/nand/mxs_nand.c
@@ -148,6 +148,13 @@ static inline uint32_t
mxs_nand_get_ecc_strength(uint32_t page_data_size,
{
int ecc_strength;
+ /* Determine the ECC layout with the formula:
wrong comment style ... please fix also in patch 4/4... thanks.
Checkpatch did not complain and I did not know there is a coding
style
for comments. Should it be:
/*
* Determine the ECC layout...
Yes.
See: linux:/Documentation/CodingStyle search for
"The preferred style for long (multi-line) comments is"
Thanks! So shall I send a v3 for this patch or will this be fixed by a
maintainer?
Please sent a v3 ... and add Scott Wood <scottw...@freescale.com>
to Cc as he is the nand maintainer, thanks!
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
