Hello Stefan, Am 13.03.2015 um 14:25 schrieb Stefan Roese: > Hi Markus, > > On 13.03.2015 10:05, Markus Niebel wrote: >>> >>> Not sure if I understand this correctly. Could you give an example? Again, >>> my current baseboard has no SPI at all. >>> >> >> tqma6_iomux_spi is for the SPI controller the serial nor is connected, >> so baseboard specific data are additional CS. >> >> You could solve the data duplication using >> >> #define TQMA6_BB_ECSPI1_CS_GPIO IMX_GPIO_NR(n, mm), >> #define TQMA6_BB_CS_PAD_CTRL NEW_PAD_CTRL(MX6_PAD_bla__GPIOn, IOmm, >> <PAD_CTRL) >> >> and in the board file: >> >> if !defined(TQMA6_BB_ECSPI1_CS_GPIO) >> #define TQMA6_BB_ECSPI1_CS_GPIO >> #endif >> >> static unsigned const tqma6_ecspi1_cs[] = { >> TQMA6_SF_CS_GPIO, >> TQMA6_BB_ECSPI1_CS_GPIO >> }; >> >> But OK, this looks not very nice >> >> As I said, not completely ready, but would prevent some code duplication. > > With my current approach we have code duplication. I suggest we give this > version a try and see if it scales for other, future baseboards as well. If > not, we can always try a solution like you described above. > > Okay?
Yes, Okay. you can add my Acked-by > > Thanks, > Stefan > Regards Markus _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot