On Fri, 2015-02-20 at 12:23 -0700, Simon Glass wrote:
> +Stephen who knows more about this stuff
> 
> On 19 February 2015 at 15:41, Sjoerd Simons
> <[email protected]> wrote:
> > Define the common shared block environment for the host interface in
> > preperation for the sandbox build to use config_distro_bootcmd.
> >
> > Signed-off-by: Sjoerd Simons <[email protected]>
> > ---
> >  include/config_distro_bootcmd.h | 13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/include/config_distro_bootcmd.h 
> > b/include/config_distro_bootcmd.h
> > index 07a0b3b..ff0e3a8 100644
> > --- a/include/config_distro_bootcmd.h
> > +++ b/include/config_distro_bootcmd.h
> > @@ -32,6 +32,18 @@
> >  #define BOOTENV_DEV_NAME_BLKDEV(devtypeu, devtypel, instance) \
> >         #devtypel #instance " "
> >
> > +#ifdef CONFIG_SANDBOX
> > +#define BOOTENV_SHARED_HOST    BOOTENV_SHARED_BLKDEV(host)
> > +#define BOOTENV_DEV_HOST       BOOTENV_DEV_BLKDEV
> > +#define BOOTENV_DEV_NAME_HOST  BOOTENV_DEV_NAME_BLKDEV
> > +#else
> > +#define BOOTENV_SHARED_HOST
> > +#define BOOTENV_DEV_HOST \
> > +       BOOT_TARGET_DEVICES_references_HOST_without_CONFIG_SANDBOX
> > +#define BOOTENV_DEV_NAME_HOST \
> 
> Can we use upper case in #defines?

The reason for this is that it is consistent with all other block device
blocks in that file e.g:

#define BOOTENV_DEV_SATA \
   BOOT_TARGET_DEVICES_references_SATA_without_CONFIG_CMD_SATA

So i'd prefer to to keep it that way. Btw, note that this is used for
compile time error reporting rather then something you'd refer to in
code.

-- 
Sjoerd Simons <[email protected]>
Collabora Ltd.

Attachment: smime.p7s
Description: S/MIME cryptographic signature

_______________________________________________
U-Boot mailing list
[email protected]
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to