Hi Albert, On Fri, Feb 6, 2015 at 8:18 AM, Albert ARIBAUD <albert.u.b...@aribaud.net> wrote: > Hello Bin, > > On Thu, 5 Feb 2015 14:58:35 +0800, Bin Meng <bmeng...@gmail.com> wrote: >> Hi Simon, >> >> On Thu, Feb 5, 2015 at 6:35 AM, Bin Meng <bmeng...@gmail.com> wrote: >> > Hi Simon, >> > >> > On Thu, Feb 5, 2015 at 12:25 AM, Simon Glass <s...@chromium.org> wrote: >> >> Hi Bin, >> >> >> >> On 3 February 2015 at 04:45, Bin Meng <bmeng...@gmail.com> wrote: >> >>> Turn on the Memory Reference code build in the quark Makefile. >> >>> >> >>> Signed-off-by: Bin Meng <bmeng...@gmail.com> >> >>> --- >> >>> >> >>> arch/x86/cpu/quark/Makefile | 1 + >> >>> 1 file changed, 1 insertion(+) >> >>> >> >>> diff --git a/arch/x86/cpu/quark/Makefile b/arch/x86/cpu/quark/Makefile >> >>> index 168c1e6..e87b424 100644 >> >>> --- a/arch/x86/cpu/quark/Makefile >> >>> +++ b/arch/x86/cpu/quark/Makefile >> >>> @@ -5,4 +5,5 @@ >> >>> # >> >>> >> >>> obj-y += car.o dram.o msg_port.o quark.o >> >>> +obj-y += mrc.o mrc_util.o hte.o smc.o >> >>> obj-$(CONFIG_PCI) += pci.o >> >> >> >> Would prefer that you do this as you add each file (i.e. in the patch >> >> that adds the file). >> >> >> > >> > OK, will squash this one to previous commits. >> >> Sorry I was replying too fast. Looks that I cannot add each file to >> Makefile each time, because it will not build until the 3rd patch is >> in place to provide all header files needed. > > Can't you reorder the patches so that things build properly at each > addition? IF you can't, then there is a cross-dependency, and the > cross-dependent patches (and only these!) should be made into a single > patch. >
I wanted to put them all together as a single patch before, but there is a 100KB email limit on this mailing list. So each patch was created like this, a <xxx.c> with its header <xxx.h>. Yes, I could just put all header files into one patch. Then add each <xxx.c> as a single patch and enable the build. Anyway, so far this patch series does not break any bisectability. Regards, Bin _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
