HI Axel, On 31 January 2015 at 07:23, Axel Lin <axel....@ingics.com> wrote: > Pass bank rather than bank->base to _get_gpio_direction(). > > Signed-off-by: Axel Lin <axel....@ingics.com> > --- > drivers/gpio/omap_gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c > index f3a7ccb..19fc451 100644 > --- a/drivers/gpio/omap_gpio.c > +++ b/drivers/gpio/omap_gpio.c > @@ -291,7 +291,7 @@ static int omap_gpio_get_function(struct udevice *dev, > unsigned offset) > struct gpio_bank *bank = dev_get_priv(dev); > > /* GPIOF_FUNC is not implemented yet */ > - if (_get_gpio_direction(bank->base, offset) == OMAP_GPIO_DIR_OUT) > + if (_get_gpio_direction(bank, offset) == OMAP_GPIO_DIR_OUT) > return GPIOF_OUTPUT; > else > return GPIOF_INPUT;
Ah yes another reason why we need a struct rather than void * in struct gpio_bank. Thanks for the patch, will pick up for u-boot-dm. Acked-by: Simon Glass <s...@chromium.org> Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
