Hi Simon,

On 01/31/2015 02:25 AM, Simon Glass wrote:
On 29 January 2015 at 04:21, Nikita Kiryanov <nik...@compulab.co.il> wrote:
We now have api functions that can support compiling simplefb code as its own
module. Since this code is not part of the display functionality, extract it
to its own file.

Raspberry Pi config file is updated to compile the new file.

Signed-off-by: Nikita Kiryanov <nik...@compulab.co.il>
Cc: Simon Glass <s...@chromium.org>
Cc: Anatolij Gustschin <ag...@denx.de>
Cc: Stephen Warren <swar...@wwwdotorg.org>

Reviewed-by: Simon Glass <s...@chromium.org>

Could even go in fdtdec.c if you like.

Hmm... I'm a little torn, but in the long term I think it's better to keep
subsystem-specific fdt code in separate files, because otherwise fdtdec.c will
eventually grow to enormous proportions.


---
  board/raspberrypi/rpi/rpi.c |  1 +
  common/Makefile             |  1 +
  common/lcd.c                | 50 --------------------------------------
  common/lcd_simplefb.c       | 59 +++++++++++++++++++++++++++++++++++++++++++++
  include/fdt_simplefb.h      | 14 +++++++++++
  include/lcd.h               |  3 ---
  6 files changed, 75 insertions(+), 53 deletions(-)
  create mode 100644 common/lcd_simplefb.c
  create mode 100644 include/fdt_simplefb.h

--
Regards,
Nikita Kiryanov
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to