Hi Rob,
> On Thu, Jan 29, 2015 at 2:30 AM, Lukasz Majewski
> <l.majew...@samsung.com> wrote:
> > Hi Rob,
> >
> >> From: Michael Scott <michael.sc...@linaro.org>
> >>
> >> Add code stub to handle "fastboot oem __" command. As unlock is a
> >> common fastboot command, distinguish that it is not implemented.
> >>
> >> Signed-off-by: Michael Scott <michael.sc...@linaro.org>
> >> Signed-off-by: Rob Herring <r...@kernel.org>
> >> ---
> >> drivers/usb/gadget/f_fastboot.c | 15 +++++++++++++++
> >> 1 file changed, 15 insertions(+)
> >>
> >> diff --git a/drivers/usb/gadget/f_fastboot.c
> >> b/drivers/usb/gadget/f_fastboot.c index 310175a..e2fda86 100644
> >> --- a/drivers/usb/gadget/f_fastboot.c
> >> +++ b/drivers/usb/gadget/f_fastboot.c
> >> @@ -513,6 +513,17 @@ static void cb_flash(struct usb_ep *ep, struct
> >> usb_request *req) }
> >> #endif
> >>
> >> +static void cb_oem(struct usb_ep *ep, struct usb_request *req)
> >> +{
> >> + char *cmd = req->buf;
> >> + if (strncmp("unlock", cmd + 4, 8) == 0) {
> >> + fastboot_tx_write_str("FAILnot implemented");
> >> + }
> >> + else {
> >> + fastboot_tx_write_str("FAILunknown oem command");
> >> + }
> >
> > Just a minor comment - those braces could be removed.
>
> When the format command is added in the next patch, then they need to
> be added back if you want all clauses to be the same (braces or not).
Then the patch can stay as it is. Thanks for explanation :-)
>
> Rob
>
> > BTW: Marek shall I take those patches to dfu tree or would you take
> > them to -usb tree ?
> >
> >> +}
> >> +
> >> struct cmd_dispatch_info {
> >> char *cmd;
> >> void (*cb)(struct usb_ep *ep, struct usb_request *req);
> >> @@ -541,6 +552,10 @@ static const struct cmd_dispatch_info
> >> cmd_dispatch_info[] = { .cb = cb_flash,
> >> },
> >> #endif
> >> + {
> >> + .cmd = "oem",
> >> + .cb = cb_oem,
> >> + },
> >> };
> >>
> >> static void rx_handler_command(struct usb_ep *ep, struct
> >> usb_request *req)
> >
> >
> >
> > --
> > Best regards,
> >
> > Lukasz Majewski
> >
> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
