Hi Giulio,
> Detlev Zundel wrote:
>
>> Hi Giulio,
>>
>>> Signed-off-by: giulio.bene...@micronovasrl.com
>>
>> Can you please provide a somewhat more descriptive description? It may
>> be obvious for you what this does (or what new features can now be
>> used), but it isn't for me.
[...]
> You're right, sorry.
> This patch add support for Rgb 555 bits following a precise hardware wiring
> that should be more correct respect the at91sam9263ek.
> I mean
> LCD2 - LCD7 are RED0 - RED4,
> LCD10 - LCD15 are GREEN0 - GREEN4,
> LCD18 - LCD23 are BLUE0 - BLUE4
Hm, I still don't get what your patch does. Is this the wiring which is
actually used on the at91sam9263ek? If so, then why does your patch not
add this symbol in include/configs/at91sam9263ek.h? In there I see the
said CONFIG_ATMEL_LCD_BGR555. That symbol is also defined for the
at91cap9adk, at91sam9261ek and pm9263.h. So what I would really like to
know - is the interpretation of CONFIG_ATMEL_LCD_BGR555 correct in
U-Boot and only the at91sam9263ek is wired up differently? Or should
rather the interpretation of CONFIG_ATMEL_LCD_BGR555 be fixed?
> Regarding "LCD_BGR555", it is correct only because at91sam9263ek was wired
> swapped between red and blue. It should be in that way but I'm not sure.
> Anyway I think the wiring should be done better before, instead of create a
> new "standard". Fortunately with software you can change more than
> something, but not everything.
Ah, so this means that the at91sam9263ek is special compared to the
other boards listed above and should be treated differently, right?
Well in this case, your patch certainly needs to change
include/configs/at91sam9263ek.h.
Cheers
Detlev
--
Peace of mind isn't at all superficial to technical work. It's the
whole thing. That which produces it is good work and that which
destroys it is bad work.
-- Robert M. Pirsig
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-40 Fax: (+49)-8142-66989-80 Email: d...@denx.de
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
