Hi,
On 19-12-14 11:06, Siarhei Siamashka wrote:
On Tue, 16 Dec 2014 21:31:35 +0100
Hans de Goede <hdego...@redhat.com> wrote:
The await_completion helper is already copy pasted between the sun4i and sun6i
dram code, and we need it for sun8i too, so lets make it an inline helper in
dram.h, rather then adding yet another copy.
Signed-off-by: Hans de Goede <hdego...@redhat.com>
Making this function "static inline" and placing it into a header file
encourages the compiler to actually inline it. Which is not great for
code size:
== Before the patch and using gcc version 4.8.3 ==
$ arm-none-linux-gnieabi-size spl/arch/arm/cpu/armv7/sunxi/dram_sun4i.o
text data bss dec hex filename
1731 0 0 1731 6c3
$ arm-none-linux-gnieabi-size spl/arch/arm/cpu/armv7/sunxi/dram_sun6i.o
text data bss dec hex filename
1841 0 0 1841 731
== After the patch and using gcc version 4.8.3 ==
$ arm-none-linux-gnieabi-size spl/arch/arm/cpu/armv7/sunxi/dram_sun4i.o
text data bss dec hex filename
1763 0 0 1763 6e3
$ arm-none-linux-gnieabi-size spl/arch/arm/cpu/armv7/sunxi/dram_sun6i.o
text data bss dec hex filename
1983 0 0 1983 7bf
Ah, thanks for catching that, the size increase does not seem to be a problem
right now, but it certainly is something to keep in mind.
Could we perhaps just introduce something like a new source file
"dram_common.c" or even "dram.c"?
Sounds like a good idea, patches welcome.
As an additional observation, moving await_bits_clear/await_bits_set
functions into a common header file and using them in the sun6i dram
code might improve readability.
Sounds like another good idea, patches welcome.
Regards,
Hans
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
