Dear Mike Frysinger, In message <1245143108-7334-1-git-send-email-vap...@gentoo.org> you wrote: > Rather than rely on dirty hacks to compile the environment on the host and > extract the CRC from that, have envcrc extract the environment straight > from the ELF object that will be linked into u-boot itself. This makes > the envcrc code a bit more complicated, but it simplifies the build > process and host requirements because we don't have to try and recreate > the environment that the target will be seeing on the host. This avoids > some issues that crop up from time to time where the preprocessor defines > on the host don't expand in the same way as for the target -- in case the > target uses those defines to customize the environment, or the host > defines conflicts with some of the target values.
Can you please be a bit more specific about which sort of problems you are talking here? We've been using this code for many years now, but I cannot remember any problems with it. > Signed-off-by: Mike Frysinger <vap...@gentoo.org> > --- > common/Makefile | 4 +- > common/env_embedded.c | 30 +--------- > tools/Makefile | 3 +- > tools/envcrc.c | 156 > ++++++++++++++++++++++++++++++++++++++++++------- The diffstat indicates that the new solution is more complicated than the old one, so I'd like to understand why this is needed (or if). Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de If it has syntax, it isn't user friendly. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
