Hi!
On Thu 2014-11-13 13:20:52, Wolfgang Denk wrote:
> Dear Pavel Machek,
>
> In message <20141113120956.GB30779@amd> you wrote:
> >
> > diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
> > index 507b9a3..06a31b0 100644
> > --- a/drivers/net/phy/micrel.c
> > +++ b/drivers/net/phy/micrel.c
> > @@ -112,17 +112,46 @@ static int ksz9021_phy_extwrite(struct phy_device
> > *phydev, int addr,
> > return ksz9021_phy_extended_write(phydev, regnum, val);
> > }
> >
> > +
> > +
>
> Please don't add excessive white space / blank lines.
>
> > + printf("ksz9021: configuring\n");
> > +
> > + printf("Configuring PHY skew timing for %s\n",
> > + phydev->drv->name);
>
> Should these eventually be changed into debug() ?
>
> Output gets really noisy otherwise.
>
> > if (getenv("disable_giga"))
>
> Should we not rather use the standard "hwconf" approach here?
Comments accepted (this was just a test patch I hand edited it, thats
why it was so ugly), but we need to decide, first, which approach to
take. (Configuration in environment vs. configuration in config file
vs. hardcoded configuration in .c file.). Then, clean patch can be
prepared.
I wanted to sign it off, so that it is clear it can be used as a basis
for better patch, but I was aware it is not clean enough for merging
-- how do I do that?
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures)
http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
