The following patches clean up a number of errors and warnings detected by running the "cppcheck" [1] tool over the U-Boot source tree. This discovers a number of issues that escape GCC, for example because they are inside #ifdef branches which are never compiled for any of the tested configurations.
This is just an initial patch series; some other error reports have been sent to the respective code maintainers, so more patches should follow soon. The command used for these tests was: $ cd u-boot $ cppcheck --force --quiet --inline-suppr . [1] http://cppcheck.sourceforge.net/ Wolfgang Denk (9): cppcheck cleanup: fix nullPointer errors board/cogent/lcd.c: fix syntax error drivers/usb/host/isp116x-hcd.c: fix syntax error drivers/net/uli526x.c: fix syntax error common/cmd_fitupd.c: restore corrupted file board/matrix_vision/mvblx/sys_eeprom.c: fix buffer overflow board/renesas/ecovec/ecovec.c: fix buffer overflow ARM: MXS: fix Uninitialized variable error board/esd/common/auto_update.c: fix Uninitialized variable arch/arm/cpu/arm926ejs/mxs/mxs.c | 2 ++ arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 2 ++ arch/arm/cpu/arm926ejs/mxs/timer.c | 2 ++ arch/arm/cpu/armv7/zynq/ddrc.c | 1 + arch/blackfin/cpu/initcode.c | 1 + arch/powerpc/cpu/mpc85xx/cpu_init_early.c | 5 ++++- arch/sh/lib/zimageboot.c | 1 + board/cogent/lcd.c | 2 +- board/esd/common/auto_update.c | 3 +-- board/esd/pci405/cmd_pci405.c | 4 +++- board/keymile/common/common.c | 1 + board/matrix_vision/mvblx/sys_eeprom.c | 2 +- board/renesas/ecovec/ecovec.c | 2 +- board/scb9328/flash.c | 2 ++ common/cmd_fitupd.c | 14 +++++--------- drivers/net/uli526x.c | 2 +- drivers/usb/host/isp116x-hcd.c | 2 +- 17 files changed, 30 insertions(+), 18 deletions(-) -- 1.8.3.1 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot