Hi,
Thanks for youre review.
2014-11-06 15:10 GMT+09:00 Masahiro Yamada <yamad...@jp.panasonic.com>:
> Hi Nobuhiro,
>
>
> On Tue, 4 Nov 2014 16:33:02 +0900
> Nobuhiro Iwamatsu <nobuhiro.iwamatsu...@renesas.com> wrote:
>
>> diff --git a/configs/gose_defconfig b/configs/gose_defconfig
>> new file mode 100644
>> index 0000000..e764583
>> --- /dev/null
>> +++ b/configs/gose_defconfig
>> @@ -0,0 +1,3 @@
>> +CONFIG_ARM=y
>> ++S:CONFIG_RMOBILE=y
>> +CONFIG_TARGET_GOSE=y
>
>
> "+S" is unnecessary unless this board turns on SPL.
>
> I guess you referenced other Rmobile defconfigs.
> Sorry, my conversion mistake.
> (I do not remember why this happened.)
>
> "+S:CONFIG_RMOBILE=y" should be "CONFIG_RMOBILE=y"
> also for {kzm9g, lager, koelsch, armadillo-800eva, alt}_defconfig.
>
> I have not found time to fix them.
>
>
I see. I will fix.
>
>
>> diff --git a/include/configs/gose.h b/include/configs/gose.h
>> new file mode 100644
>> index 0000000..0af2778
>> --- /dev/null
>> +++ b/include/configs/gose.h
>> @@ -0,0 +1,151 @@
>> +/*
>> + * include/configs/gose.h
>> + *
>> + * Copyright (C) 2014 Renesas Electronics Corporation
>> + *
>> + * SPDX-License-Identifier: GPL-2.0
>> + */
>> +
>> +#ifndef __GOSE_H
>> +#define __GOSE_H
>> +
>> +#undef DEBUG
>> +#define CONFIG_ARMV7
>
>
> If you have a chance to send v2,
> I recommend to drop the CONFIG_ARMV7 define.
>
> I am removing this macro.
> http://patchwork.ozlabs.org/patch/407305/
Yes, I know. I already fix this in my local repo.
>
>
> Best Regards
> Masahiro Yamada
>
Best regards,
Nobuhiro
--
Nobuhiro Iwamatsu
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
