On Tuesday, November 04, 2014 at 01:56:41 AM, Nobuhiro Iwamatsu wrote:
Hi!
> R8A7793 has same IP of USB controller as R8A7791 and R8A7794 of rmobile
> ARM SoCs. This adds support R8A7793 to EHCI HCD of rmobile.
>
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu...@renesas.com>
> ---
> drivers/usb/host/ehci-rmobile.c | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/usb/host/ehci-rmobile.c
> b/drivers/usb/host/ehci-rmobile.c index 0d1a726..a89f04b 100644
> --- a/drivers/usb/host/ehci-rmobile.c
> +++ b/drivers/usb/host/ehci-rmobile.c
> @@ -27,6 +27,11 @@ static u32
> usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = { 0xEE080000, /* USB0
> (EHCI) */
> 0xEE0C0000, /* USB1 */
> };
> +#elif defined(CONFIG_R8A7793)
> +static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
> + 0xEE080000, /* USB0 (EHCI) */
> + 0xEE0C0000, /* USB1 */
> +};
I see you combined those three arrays in the next patch, thanks!
> #elif defined(CONFIG_R8A7794)
> static u32 usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT] = {
> 0xEE080000, /* USB0 (EHCI) */
btw. just an idea, but you don't need to explicitly use
usb_base_address[CONFIG_USB_MAX_CONTROLLER_COUNT], you can
just use usb_base_address[] in the array definition. Then,
in the code, you can just use "ARRAY_SIZE(usb_base_address) - 1"
instead of CONFIG_USB_MAX_CONTROLLER_COUNT . This rids you of
one annoying macro in that driver ;-) If you want to implement
this, then please do so, but in a separate patch.
I'll pick these two patches now.
Thanks!
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
