Hello, In message <1242339363-28686-3-git-send-email...@denx.de> you wrote: > Several boards used different ways to specify the size of the > protected area when enabling flash write protection for the sectors > holding the environment variables: some used CONFIG_ENV_SIZE and > CONFIG_ENV_SIZE_REDUND, some used CONFIG_ENV_SECT_SIZE, and some even > a mix of both for the "normal" and the "redundant" areas. > > Normally, this makes no difference at all. However, things are > different when you have to deal with boards that can come with > different types of flash chips, which may have different sector > sizes. > > Here we may have to chose CONFIG_ENV_SECT_SIZE such that it fits the > biggest sector size, which may include several sectors on boards using > the smaller sector flash types. In such a case, using CONFIG_ENV_SIZE > or CONFIG_ENV_SIZE_REDUND to enable the protection may lead to the > case that only the first of these sectors get protected, while the > following ones aren't. > > This is no real problem, but it can be confusing for the user - > especially on boards that use CONFIG_ENV_SECT_SIZE to protect the > "normal" areas, while using CONFIG_ENV_SIZE_REDUND for the > "redundant" area. > > To avoid such inconsistencies, I changed all sucn boards that I found > to consistently use CONFIG_ENV_SECT_SIZE for protection. This should > not cause any functional changes to the code. > > Signed-off-by: Wolfgang Denk <w...@denx.de> > Cc: Paul Ruhland > Cc: Pantelis Antoniou <pa...@intracom.gr> > Cc: Stefan Roese <s...@denx.de> > Cc: Gary Jennejohn <ga...@denx.de> > Cc: Dave Ellis <d...@sixnetio.com> > --- > board/lpd7a40x/flash.c | 4 ++-- > board/mcc200/mcc200.c | 2 +- > board/netphone/flash.c | 4 ++-- > board/netta/flash.c | 4 ++-- > board/netta2/flash.c | 4 ++-- > board/netvia/flash.c | 4 ++-- > board/pleb2/flash.c | 4 ++-- > board/prodrive/pdnb3/flash.c | 2 +- > board/rmu/flash.c | 6 +++--- > board/samsung/smdk2400/flash.c | 4 ++-- > board/sixnet/flash.c | 4 ++-- > board/socrates/socrates.c | 2 +- > board/tqc/tqm85xx/tqm85xx.c | 2 +- > board/trab/flash.c | 4 ++-- > drivers/mtd/cfi_flash.c | 2 +- > 15 files changed, 26 insertions(+), 26 deletions(-)
Applied to master. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de "If that makes any sense to you, you have a big problem." -- C. Durance, Computer Science 234 _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot