Hi, On 10/11/2014 05:39 PM, Ian Campbell wrote: > On Mon, 2014-10-06 at 19:57 +0200, Hans de Goede wrote: >> Signed-off-by: Hans de Goede <hdego...@redhat.com> > > I presume that adding GPIO support to SPL isn't a problem size wise?
We do link time size checking and "./MAKEALL -s sunxi" still works fine, so yes it is not a problem. >> --- >> board/sunxi/Kconfig | 26 ++++++++++++++++++++++++++ >> drivers/mmc/sunxi_mmc.c | 21 +++++++++++++++++++++ >> include/configs/sunxi-common.h | 1 + >> 3 files changed, 48 insertions(+) >> >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig >> index 622f7b4..497b093 100644 >> --- a/board/sunxi/Kconfig >> +++ b/board/sunxi/Kconfig >> @@ -32,4 +32,30 @@ config USB_KEYBOARD >> Say Y here to add support for using a USB keyboard (typically used >> in combination with a graphical console on HDMI). >> >> +config MMC0_CD_PIN >> + string "Card detect pin for mmc0" >> + default "" >> + ---help--- >> + Set the card detect pin for mmc0, leave empty to not use cd. > > sunxi_name_to_gpio() doesn't handle the empty string directly, but I > think it will do the right thing (i.e. return -1) via a more or less > convoluted path. Did you check this? Yes I checked, it will return -1 on the empty string. > Assuming you have then: Acked-by: Ian Campbell <i...@hellion.org.uk> Regards, Hans _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
