On Wed, 2014-09-24 at 23:05 +0900, Masahiro YAMADA wrote: > Hi Scott, Tom, > > > 2014-09-12 19:43 GMT+09:00 Masahiro Yamada <yamad...@jp.panasonic.com>: > > > > On Fri, 12 Sep 2014 00:42:17 -0500 > > Chin Liang See <cl...@altera.com> wrote: > > > >> To add the Denali NAND driver support into U-Boot. > >> This driver is leveraged from Linux with commit ID > >> fdbad98dff8007f2b8bee6698b5d25ebba0471c9. For Denali > >> controller 64 variance, you need to declare macro > >> CONFIG_SYS_NAND_DENALI_64BIT. > >> > >> Signed-off-by: Chin Liang See <cl...@altera.com> > >> Cc: Scott Wood <scottw...@freescale.com> > >> Cc: Masahiro Yamada <yamad...@jp.panasonic.com> > >> --- > >> Changes for v10 > >> - Updated the commit message to include Linux driver commit ID, > >> usage of macro CONFIG_SYS_NAND_DENALI_64BIT > >> - Removed casting for memcpy function > >> - Removed NAND_CMD_LOCK_TIGHT support as no longer in latest NAND driver > > > > > > Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com> > > Reviewed-by: Masahiro Yamada <yamad...@jp.panasonic.com> > > Tested-by: Masahiro Yamada <yamad...@jp.panasonic.com> > > > > > > I am looking forward to get this driver in. > > > > > How about this patch? > > > There are only some cosmetic updates in v10. > I think enough time has passed for the review. > > If Scott could apply it, that would be the best, > but he seems really busy for Linux work these days > as he stated in http://lists.denx.de/pipermail/u-boot/2014-May/180399.html. > > Tom, > If Scott is too busy to take care of this patch, > could you apply it directly onto u-boot/master, please?
How would I go about testing that this builds? I don't see any code in the tree that defines CONFIG_NAND_DENALI, nor is it obvious which board I should add it to as a test. Also, CONFIG_SYS_NAND_DENALI_64BIT should be documented in a README, not just in the git changelog. -Scott _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
