On Tue, 2014-09-02 at 21:15 -0500, Scott Wood wrote: > On Sat, 2014-08-30 at 07:45 -0400, Tom Rini wrote: > > On Thu, Aug 28, 2014 at 11:13:40AM +0900, Masahiro Yamada wrote: > > > Hi Scott, > > > > > > > > > On Tue, 19 Aug 2014 04:47:40 -0500 > > > Chin Liang See <cl...@altera.com> wrote: > > > > > > > To add the Denali NAND driver support into U-Boot. > > > > This driver is leveraged from Linux. > > > > > > > > Signed-off-by: Chin Liang See <cl...@altera.com> > > > > Cc: Scott Wood <scottw...@freescale.com> > > > > Cc: Masahiro Yamada <yamad...@jp.panasonic.com> > > > > --- > > > > Changes for v9 > > > > - Updated the commit messageb > > > > - Removed macro kern_xx > > > > - Removed debug macro > > > > - Changed CONFIG_NAND_DENALI_64BIT to CONFIG_SYS_NAND_DENALI_64BIT > > > > > > > > > Any comments? > > > > > > If nothing, please apply this patch. > > > > I don't see anything obviously wrong here, but since Scott has reviewed > > previous versions I want to give him a little more time to ack. I'm OK > > pulling this into master with Scott's ack or lets say Wednesday next > > week and we'll ask Chin Liang to address any late feedback. Thanks all! > > I still don't see a reference to the SHA of the corresponding Linux > driver. >
I will add it in commit message. Its fdbad98dff8007f2b8bee6698b5d25ebba0471c9 > #define MODE5_WORKAROUND 0 still exists even though it's never used. > Sorry as forget to update the header file. Done > I still see (void *) casts in memcpy -- v8 comments said "removed" but > not all instances were removed. > Done > It still introduces CONFIG_SYS_NAND_DENALI_64BIT without documenting it. I already added into comments of the code. Let me add it into commit message. Thanks Chin Liang > > -scott > > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
