On Fri, Aug 29, 2014 at 6:30 AM, Marek Vasut <ma...@denx.de> wrote:
> +int board_mmc_init(bd_t *bis)
> +{
> + s32 status = 0;
> + int index;
> +
> + usdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
> + usdhc_cfg[1].sdhc_clk = mxc_get_clock(MXC_ESDHC2_CLK);
> +
> + for (index = 0; index < ARRAY_SIZE(usdhc_cfg); index++)
> + status |= fsl_esdhc_initialize(bis, &usdhc_cfg[index]);
> +
> + return status;
Instead of ORing the errors you should better just return 'status'
immediately in the case of failure.
> +/* setup board specific PMIC */
> +int power_init_board(void)
> +{
> + struct pmic *p;
> + u32 reg;
> + int ret;
> +
> + power_pfuze100_init(1);
> + p = pmic_get("PFUZE100_PMIC");
In Stefano's tree there is no more PFUZE100_PMIC. It is called PFUZE100 now.
> +/* Extra U-Boot environment. */
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> + "fdt_high=0xffffffff\0" \
> + "initrd_high=0xffffffff\0" \
> + "consdev=ttymxc1\0" \
> + "baudrate=115200\0" \
> + "bootdev=/dev/mmcblk0p1\0" \
> + "rootdev=/dev/mmcblk0p2\0" \
> + "netdev=eth0\0" \
> + "rootpath=/opt/eldk-5.5/armv7a-hf/rootfs-qte-sdk\0" \
This seems to be a too specific rootpath name. Not everyone will use
this same rootpath.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
