[U-Boot] [PATCH v2 2/2] pxe: Allow use of environment variables in append string

[Hans de Goede]

Use cli_simple_process_macros, so that environment
variables (e.g. ${console}) can be used in append strings.

Signed-off-by: Hans de Goede <hdego...@redhat.com>

--
Changes in v2:
-Use cli_simple_process_macros instead of run_cmd("setenv bootargs ..."), so
 that only $() / ${} get processed and not ;
---
 common/cmd_pxe.c | 29 +++++++++++++----------------
 1 file changed, 13 insertions(+), 16 deletions(-)

diff --git a/common/cmd_pxe.c b/common/cmd_pxe.c
index ba48692..bd7aa65 100644
--- a/common/cmd_pxe.c
+++ b/common/cmd_pxe.c
@@ -14,6 +14,7 @@
 #include <fs.h>
 
 #include "menu.h"
+#include "cli.h"
 
 #define MAX_TFTP_PATH_LEN 127
 
@@ -577,8 +578,12 @@ static int label_localboot(struct pxe_label *label)
        if (!localcmd)
                return -ENOENT;
 
-       if (label->append)
-               setenv("bootargs", label->append);
+       if (label->append) {
+               char bootargs[CONFIG_SYS_CBSIZE];
+
+               cli_simple_process_macros(label->append, bootargs);
+               setenv("bootargs", bootargs);
+       }
 
        debug("running: %s\n", localcmd);
 
@@ -606,7 +611,6 @@ static int label_boot(cmd_tbl_t *cmdtp, struct pxe_label 
*label)
        char initrd_str[22];
        char mac_str[29] = "";
        char ip_str[68] = "";
-       char *bootargs;
        int bootm_argc = 3;
        int len = 0;
 
@@ -651,7 +655,6 @@ static int label_boot(cmd_tbl_t *cmdtp, struct pxe_label 
*label)
                sprintf(ip_str, " ip=%s:%s:%s:%s",
                        getenv("ipaddr"), getenv("serverip"),
                        getenv("gatewayip"), getenv("netmask"));
-               len += strlen(ip_str);
        }
 
 #ifdef CONFIG_CMD_NET
@@ -661,27 +664,21 @@ static int label_boot(cmd_tbl_t *cmdtp, struct pxe_label 
*label)
                err = format_mac_pxe(mac_str + 8, sizeof(mac_str) - 8);
                if (err < 0)
                        mac_str[0] = '\0';
-               len += strlen(mac_str);
        }
 #endif
 
-       if (label->append)
-               len += strlen(label->append);
+       if ((label->ipappend & 0x3) || label->append) {
+               char bootargs[CONFIG_SYS_CBSIZE] = "";
+               char finalbootargs[CONFIG_SYS_CBSIZE];
 
-       if (len) {
-               bootargs = malloc(len + 1);
-               if (!bootargs)
-                       return 1;
-               bootargs[0] = '\0';
                if (label->append)
                        strcpy(bootargs, label->append);
                strcat(bootargs, ip_str);
                strcat(bootargs, mac_str);
 
-               setenv("bootargs", bootargs);
-               printf("append: %s\n", bootargs);
-
-               free(bootargs);
+               cli_simple_process_macros(bootargs, finalbootargs);
+               setenv("bootargs", finalbootargs);
+               printf("append: %s\n", finalbootargs);
        }
 
        bootm_argv[1] = getenv("kernel_addr_r");
-- 
2.0.4

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot