On 25/07/2014 20:19, Stefan Roese wrote: > On 25.07.2014 19:07, Gerald Kerma wrote: >> This patch add Marvell kirkwood MVSDIO/MMC driver >> and enable it for Sheevaplugs and OpenRD boards. >> >> Signed-off-by: Gerald Kerma <[email protected]> > > Thanks. This really looks better. > > Only some mostly nitpicking comments below.
correction added in next version. >> diff --git a/include/configs/sheevaplug.h b/include/configs/sheevaplug.h >> index ecc93bc..de38ad3 100644 >> --- a/include/configs/sheevaplug.h >> +++ b/include/configs/sheevaplug.h >> @@ -31,9 +31,11 @@ >> #define CONFIG_CMD_DHCP >> #define CONFIG_CMD_ENV >> #define CONFIG_CMD_MII >> +#define CONFIG_CMD_MMC >> #define CONFIG_CMD_NAND >> #define CONFIG_CMD_PING >> #define CONFIG_CMD_USB >> + >> /* >> * mv-common.h should be defined after CMD configs since it used them >> * to enable certain macros >> @@ -49,13 +51,14 @@ >> #else >> #define CONFIG_ENV_IS_NOWHERE 1 /* if env in SDRAM */ >> #endif >> + >> /* >> * max 4k env size is enough, but in case of nand >> * it has to be rounded to sector size >> */ >> #define CONFIG_ENV_SIZE 0x20000 /* 128k */ >> -#define CONFIG_ENV_ADDR 0x60000 >> -#define CONFIG_ENV_OFFSET 0x60000 /* env starts here */ >> +#define CONFIG_ENV_ADDR 0x80000 >> +#define CONFIG_ENV_OFFSET 0x80000 /* env starts here */ > > This change seems to be unrelated. And breaks compatibility with the > environment. Or am I missing something? Removed, but, the new u-boot.kwb image is greater than 0x60000. If you write environments or reset environments that will corrupt uboot and broke it. May be fixed in another patch. > Thanks for your patience! > > Stefan V7 sent. Enjoy,
signature.asc
Description: OpenPGP digital signature
_______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
