On Fri, 2014-07-04 at 16:59 +0200, Marek Vasut wrote: > On Saturday, May 31, 2014 at 06:36:12 PM, Ian Campbell wrote: > > This has been disabled for ARM in initr_scsi since that function was > > introduced. However it works fine for me on Cubieboard and Cubietruck (with > > the upcoming AHCI glue patch). > > Does this break bisectability ?
Not if this patch goes in first. > > I also tested on two random ARM platforms which seem to define > > CONFIG_CMD_SCSI: - highbank worked fine (on midway hardware) > > - omap5_uevm built OK and I confirmed using objdump that things were as > > expected (i.e. the default weak scsi_init nop was used). > > > > While there remove the mismatched comment from the #endif (omitting the > > comment seems to be the prevailing style in this file) and add a missing > > return to initr_doc which I happened to spot while editing. > > > > Signed-off-by: Ian Campbell <i...@hellion.org.uk> > > Cc: Simon Glass <s...@chromium.org> > > Make sure to check no ARM boards call scsi_init() from their board files. I grepped around and couldn't find any. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
