On 6/3/2014 10:35 PM, Simon Glass wrote:
Hi Josh,

On 3 June 2014 03:52, Josh Wu <josh...@atmel.com> wrote:
When the map_sysmem, then the fatwrite command can support sandbox.
Following command will show how to use it:
   => sb bind 0 sd.img
   => fatls host 0
   => fatwrite host 0 $memaddr filename $filesize

Signed-off-by: Josh Wu <josh...@atmel.com>
---
  common/cmd_fat.c |    6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/common/cmd_fat.c b/common/cmd_fat.c
index a12d8fa..21a2145 100644
--- a/common/cmd_fat.c
+++ b/common/cmd_fat.c
@@ -13,6 +13,7 @@
  #include <s_record.h>
  #include <net.h>
  #include <ata.h>
+#include <asm/io.h>
  #include <part.h>
  #include <fat.h>
  #include <fs.h>
@@ -93,6 +94,7 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag,
         disk_partition_t info;
         int dev = 0;
         int part = 1;
+       void *buf;

         if (argc < 5)
                 return cmd_usage(cmdtp);
@@ -111,7 +113,9 @@ static int do_fat_fswrite(cmd_tbl_t *cmdtp, int flag,
         addr = simple_strtoul(argv[3], NULL, 16);
         count = simple_strtoul(argv[5], NULL, 16);

-       size = file_fat_write(argv[4], (void *)addr, count);
+       buf = map_sysmem((void *)addr, count);
Thanks for the patch.

You should remove the cast here - map_sysmem()'s first parameter is a
U-Boot address as a ulong.
Ah, Right. Thank for pointing that. I'll fixed in v2.

Best Regards,
Josh Wu

+       size = file_fat_write(argv[4], buf, count);
+       unmap_sysmem(buf);
         if (size == -1) {
                 printf("\n** Unable to write \"%s\" from %s %d:%d **\n",
                         argv[4], argv[1], dev, part);
--
1.7.9.5

Regards,
Simon

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to