On 31 May 2014 14:32, Jeroen Hofstee <jer...@myspectrum.nl> wrote: > When CONFIG_SYS_GENERIC_GLOBAL_DATA is not set the arch handles > the assignment of gd. At least in case of ARM/Aarch64 this means > board_init_r is alteady called with the new gd. Therefore only > assign gd if CONFIG_SYS_GENERIC_GLOBAL_DATA is defined.
I think you might be missing a signoff (you might consider using patman). Apart from that it looks good. Acked-by: Simon Gass <s...@chromium.org> > --- > common/board_r.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/board_r.c b/common/board_r.c > index 602a239..18bbe26 100644 > --- a/common/board_r.c > +++ b/common/board_r.c > @@ -927,7 +927,7 @@ void board_init_r(gd_t *new_gd, ulong dest_addr) > int i; > #endif > > -#ifndef CONFIG_X86 > +#ifdef CONFIG_SYS_GENERIC_GLOBAL_DATA > gd = new_gd; > #endif > > -- > 1.8.3.2 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
