On 17 April 2014 22:41, Masahiro Yamada <yamad...@jp.panasonic.com> wrote: > - Do not use a deep indentation. We have only 80-character > on each line and 1 indentation consumes 8 spaces. Before the > code moves far to the right, you should consider to > fix your code. See Linux Documentation/CodingStyle. > > - Add CONFIG_OF_STDOUT_VIA_ALIAS and OF_STDOUT_PATH macros > only to their definition. Do not add them to both > callee and caller. This is a tip to avoid using #ifdef > everywhere. > > - OF_STDOUT_PATH and CONFIG_OF_STDOUT_VIA_ALIAS are exclusive. > If both are defined, the former takes precedence. > Do not try to fix-up "linux,stdout-path" property twice. > > Signed-off-by: Masahiro Yamada <yamad...@jp.panasonic.com>
Acked-by: Simon Glass <s...@chromium.org> > --- > > Changes in v2: None > > common/fdt_support.c | 85 > ++++++++++++++++++++++++++-------------------------- > 1 file changed, 42 insertions(+), 43 deletions(-) _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
