On Tue, May 13, 2014 at 07:27:18PM +1200, Charles Manning wrote: > On Tuesday 13 May 2014 08:26:44 Tom Rini wrote: > > On Tue, May 06, 2014 at 10:46:46AM +1200, Charles Manning wrote: > > > mxsimage uses the same crc32 function as pblimage. > > > > > > Signed-off-by: Charles Manning <cdhmann...@gmail.com> > > > Acked-by: Stefano Babic <sba...@denx.de> > > > > This introduces warnings: > > tools/mxsimage.c: In function ‘sb_build_command_load’: > > tools/mxsimage.c:979:2: warning: pointer targets in passing argument 2 of > > ‘pbl_crc32’ differ in signedness [-Wpointer-sign] tools/pbl_crc32.h:11:10: > > note: expected ‘const char *’ but argument is of type ‘uint8_t *’ > > u-boot/tools/mxsimage.c: In function ‘sb_verify_command’: > > tools/mxsimage.c:1815:3: warning: pointer targets in passing argument 2 of > > ‘pbl_crc32’ differ in signedness [-Wpointer-sign] tools/pbl_crc32.h:11:10: > > note: expected ‘const char *’ but argument is of type ‘uint8_t *’ > > Thanks for the feedback. > > Will it be acceptable to do the following: > > *Change the called function from uint8_t * to const uint8_t > *Cast the const char * pointer to const uint8_t *.
Sounds right. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
