Re: [U-Boot] [PATCH v6 2/9] tools: mkimage: add support for gpimage format

[Tom Rini]

On Mon, Apr 07, 2014 at 03:21:35PM +0200, Gerhard Sittig wrote:
> On Fri, 2014-04-04 at 22:45 +0200, Wolfgang Denk wrote:
> > 
> > Dear Murali Karicheri,
> > 
> > In message <1396631815-5735-3-git-send-email-m-kariche...@ti.com> you wrote:
> > > This patch add support for gpimage format as a preparatory
> > > patch for porting u-boot for keystone2 devices and is
> > > based on omapimage format. It re-uses gph header to store the
> > > size and loadaddr as done in omapimage.c
> > ...
> > > @@ -125,6 +125,7 @@ static const table_entry_t uimage_type[] = {
> > >   {       IH_TYPE_FILESYSTEM, "filesystem", "Filesystem Image",   },
> > >   {       IH_TYPE_FIRMWARE,   "firmware",   "Firmware",           },
> > >   {       IH_TYPE_FLATDT,     "flat_dt",    "Flat Device Tree",   },
> > > + {       IH_TYPE_GPIMAGE,    "gpimage",    "TI Keystone SPL Image",},
> > >   {       IH_TYPE_KERNEL,     "kernel",     "Kernel Image",       },
> > >   {       IH_TYPE_KERNEL_NOLOAD, "kernel_noload",  "Kernel Image (no 
> > > loading done)", },
> > >   {       IH_TYPE_KWBIMAGE,   "kwbimage",   "Kirkwood Boot Image",},
> > 
> > For binary compatibility with existing images you can only appen, but
> > never insert into uimage_type[].
> 
> the next hunk (declaration of the IH_TYPE_GPIMAGE enum value) did
> the append, using a number past all previously used numbers,
> keeping compatibility with existing binaries
> 
> the above hunk just references the newly introduced enum, and
> keeps the list of images sorted alphabetically -- so I think this
> is OK

Yes, agreed.

-- 
Tom

signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot