On Wed, Apr 02, 2014 at 04:06:11PM +0530, Sourav Poddar wrote:

> Add MTD partition info for qspi on dra7 evm
> 
> Signed-off-by: Sourav Poddar <sourav.pod...@ti.com>
[snip]
> +/*
> + * Default to using SPI for environment, etc.
> + * 0x000000 - 0x010000 : QSPI.SPL (64KiB)
> + * 0x010000 - 0x020000 : QSPI.SPL.backup1 (64KiB)
> + * 0x020000 - 0x030000 : QSPI.SPL.backup2 (64KiB)
> + * 0x030000 - 0x040000 : QSPI.SPL.backup3 (64KiB)
> + * 0x040000 - 0x140000 : QSPI.u-boot (1MiB)
> + * 0x140000 - 0x150000 : QSPI.u-boot-spl-os (64KiB)

This is too small, I found out when adding falcon mode support for this
board.  We need to bump this to 512KiB and then re-adjust what follows.

> +#if defined(CONFIG_QSPI_BOOT)
> +#undef CONFIG_ENV_IS_IN_MMC

... This needs adjusting too, we should only be setting
CONFIG_ENV_IS_IN_MMC on !QSPI_BOOT, up in the MMC area.

And related, we need to fix ti_omap5_common.h to not set CONFIG_ENV_SIZE
because right now it's setting 128KiB and our redundant location never
would have valid data.

I'll pick this all up in a v2 and address it, along with a few other
things.  Thanks!

-- 
Tom

Attachment: signature.asc
Description: Digital signature

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to