Dear Dongsheng Wang,
In message <1395123347-15025-2-git-send-email-dongsheng.w...@freescale.com> you
wrote:
> From: Jason Jin <jason....@freescale.com>
>
...
> +void diu_set_pixel_clock(unsigned int pixclock)
> +{
> + unsigned long speed_ccb, temp;
> + u32 pixval;
> + int ret;
> + speed_ccb = get_bus_freq(0);
> + temp = 1000000000 / pixclock;
> + temp *= 1000;
> + pixval = speed_ccb / temp;
Please always separate declarations and code by a blank line.
> #define CONFIG_SYS_MONITOR_LEN (512 * 1024)
> -#define CONFIG_SYS_MALLOC_LEN (4 * 1024 * 1024)
> +/*When DIU is enabled, more malloc memory needed for fb*/
> +#define CONFIG_SYS_MALLOC_LEN (10 * 1024 * 1024)
This looks wrong to me. The FB should not be allocated using
malloc(). Instead, it is supposed to be located at the end of the
RAM - search for "reserve memory for LCD display" in
"arch/arm/lib/board.c". Yes, I am aware that you don;t use a LCD
here, but the appraoch should be the same in any case.
> @@ -352,12 +354,27 @@
> #define CONFIG_SYS_NS16550_COM3 (CONFIG_SYS_CCSRBAR+0x11D500)
> #define CONFIG_SYS_NS16550_COM4 (CONFIG_SYS_CCSRBAR+0x11D600)
> #define CONFIG_SERIAL_MULTI /* Enable both serial ports */
> -#define CONFIG_SYS_CONSOLE_IS_IN_ENV /* determine from environment */
This appears to be an unrelated change?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"The net result is a system that is not only binary compatible with
4.3 BSD, but is even bug for bug compatible in almost all features."
- Avadit Tevanian, Jr., "Architecture-Independent Virtual Memory
Management for Parallel and Distributed Environments: The Mach
Approach"
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
