On Thu, Feb 20, 2014 at 05:22:27PM +0900, Masahiro Yamada wrote: > Hello Tom, > (ccing Simon and Stephan) > > > > > > Tom, > > > Please apply this along with the Kbuild series. > > > > So with this, I then get: > > Configuring for venice2 board... > > make[2]: *** [arch/arm/dts/tegra124-venice2.dtb] Error 1 > > make[1]: *** [dts/dt.dtb] Error 2 > > make: *** [sub-make] Error 2 > > text data bss dec hex filename > > 260562 15030 309960 585552 8ef50 venice2/u-boot > > 18527 421 72 19020 4a4c venice2/spl/u-boot-spl > > > > Device Tree Source is not correctly specified. > > Please define 'CONFIG_DEFAULT_DEVICE_TREE' > > or build with 'DEVICE_TREE=<device_tree>' argument > > > > make[2]: *** [arch/arm/dts/tegra124-venice2.dtb] Error 1 > > make[1]: *** [dts/dt.dtb] Error 2 > > make: *** [sub-make] Error 2 > > > > --------------------- SUMMARY ---------------------------- > > Boards compiled: 1 > > Boards with errors: 1 ( venice2 ) > > ---------------------------------------------------------- > > > > What's going on as the config file sets CONFIG_DEFAULT_DEVICE_TREE > > > > > > Commit 5ab502cb89 has been applied and the build system > now expects device tree sources should reside under arch/$(ARCH)/dts/. > > But the device tree of venice2 board is still remaining > in board/nvidia/dts/. > This is the cause of the build error. > (Commit 5ab502cb89 had been posted before venice2 board > support was merged. So there happened an unvisible conflict.) > > Actually I did not expect dts series was applied so soon > because Simon and I was still discussing that series. > And I guess Simon is not happy about Commit 5ab502cb89. > > Anyway, we need to do something with venice2's build error > immediately. > > I think we have two options. > > [1] Move also venice2 device tree to arch/arm/dts directory. > I have posted a patch: > http://patchwork.ozlabs.org/patch/322082/ > > [2] revert the following commits in this order > 3284c8b8ca (dts: generate multiple device tree blobs) > 5ab502cb89 (dts: move device tree sources to arch/$(ARCH)/dts/) > > > If we like to gather all device trees to arch/$(ARCH)/dts, > the choice will be [1]. > > On the other hand, if we like to put *.dtsi to arch/$(ARCH)/dts > whilst *.dts to board/$(VENDOR)/dts, the choice will be [2].
Well, I think our long term plan here is (a) mirror the kernel today and since their long term plan is "move device trees out of tree, then deal with it there" once they've got a plan there, we can follow (and indeed should be contributing to the conversation). -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
