Hi FengHua, On Thu, 13 Feb 2014 10:41:07 +0800 (GMT+08:00), FengHua <feng...@phytium.com.cn> wrote:
> > > > > -----Original Messages----- > > From: "Wolfgang Denk" <w...@denx.de> > > Sent Time: 2014-02-13 06:11:01 (Thursday) > > To: "York Sun" <york...@freescale.com> > > Cc: scottw...@freescale.com, u-boot@lists.denx.de > > Subject: Re: [U-Boot] [RFC] Add 64-bit data support for memory commands > > > > Dear York Sun, > > > > In message <1392240023-25205-1-git-send-email-york...@freescale.com> you > > wrote: > > > For aarch64, unsigned long is 64-bit data. Memory commands should be fixed > > > with u32 for 32-bit address access. A double word data size is added to > > > support 64-bit data. > > > > > > Signed-off-by: York Sun <york...@freescale.com> > > > > Can you please make all this code conditional for 64 bit architectures > > only, so that 32 bit systems do not suffer from the increased code > > size? > > > > Thanks. > > > > Best regards, > > > > Wolfgang Denk > How about use some macro from compiler of sizeof(long)? > Maybe this could avoid conditional switch, and cmd_mem work with 32 and 64 > bit platform. That would make "md.l" be 32 or 64 bits depending on the target's natural int size, wouldn't it? But then, "md.w" and "md.b" would remain fixed-size, respectively 16 and 8 bits. That would not be consistent IMO. I think "md.l" should clearly remain 32 bits, and if 64-bit is introduced in "md" and others it should be clearly recognizable e.g. as ".d" whatever the target's natural int size. > Best Wishes Amicalement, -- Albert. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
