On Tue, Feb 04, 2014 at 09:58:06AM +0900, Jaehoon Chung wrote: > On 01/31/2014 06:31 AM, Tom Rini wrote: > > Add a partconf sub-command to the mmc command to allow for setting > > the boot_ack, boot_partition and partition_access fields of > > PARTITION_CONFIG (formerly BOOT_CONFIG, EXT_CSD[179]). Part of this > > requires changing the check for 'part' from an strncmp to a strcmp, like > > the rest of the sub-commands. [snip] > > @@ -451,6 +477,8 @@ U_BOOT_CMD( > > " - Enable boot_part for booting and disable access to boot_part\n" > > "mmc bootpart-resize <dev> <boot part size MB> <RPMB part size MB>\n" > > " - Change sizes of boot and RPMB partitions of specified device\n" > > + "mmc partconf dev boot_ack boot_partition partition_access\n" > > How about using bracket("< >") for more readable? > mmc partconf <dev> <boot_ack> <boot_partition> <partition_access>
Except for bootpart-resize the rest of the mmc commands (and most in general) don't use "< >" around required parameters unless it's part of some sub-choices (such as spl export <img=atags|fdt> ...). > Anyway, looks good to me. Thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot