Hello Wolfgang,
On Mon, 2014-02-03 at 20:15 +0100, Wolfgang Denk wrote:
> Dear Alexey Brodkin,
>
> In message <1391445368-10545-7-git-send-email-abrod...@synopsys.com> you
> wrote:
> > Arcangel4 is a FPGA-based development board that is used for prototyping and
> > verification of of both ARC hardware (CPUs) and software running upon CPU.
> >
> > Prerequisite is http://patchwork.ozlabs.org/patch/300901/
>
> Is this commentuseful in the commit message?
Do you mean comment regarding Arcangel4 board itself?
I upstreamed a number of drivers in both u-Boot and Linux kernel and
each time I put a brief description of device I'm submitting sources for
in commit message.
If this is uncommon and/or redundant I may remove this message in the
next re-spin.
> > +#define CONFIG_SYS_MEMTEST_START (CONFIG_SYS_SDRAM_BASE + 0x200)
> > +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_SDRAM_BASE + 0x1234)
>
> This definitely makes no sense at all. Please see bullet 2. in
> doc/README.memory-test
Thanks, will re-visit this part.
> > +#define CONFIG_BAUDRATE 115200
> > +#define CONFIG_SYS_BAUDRATE_TABLE {9600, 19200, 38400, 57600, 115200}
>
> This is standard, isn't it? So you can omit it.
Indeed this is standard. But as I wrote earlier - since there's no
guidance (or at least I didn't manage to find it) on how to use stuff in
u-boot I went grepping through existing u-Boot sources and I saw how
it's done.
It might be once again my tough luck in selection of examples...
Regards,
Alexey
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
