Hi Ajay,
On 20 December 2013 02:43, Ajay kumar <ajayn...@gmail.com> wrote:
> Hi Simon,
>
>
> On Fri, Dec 20, 2013 at 2:10 AM, Simon Glass <s...@chromium.org> wrote:
>>
>> Hi Ajay,
>>
>> On 12 November 2013 05:27, Ajay Kumar <ajaykumar...@samsung.com> wrote:
>> > Add callbacks to set up DP-HPD, backlight and LCD power
>> > on SMDK5420.
>> >
>> > Signed-off-by: Ajay Kumar <ajaykumar...@samsung.com>
>> > ---
>> > board/samsung/smdk5420/smdk5420.c | 102
>> > +++++++-------------------------------
>> > 1 file changed, 17 insertions(+), 85 deletions(-)
>> >
>> > diff --git a/board/samsung/smdk5420/smdk5420.c
>> > b/board/samsung/smdk5420/smdk5420.c
>> > index d85b953..75b22cc 100644
>> > --- a/board/samsung/smdk5420/smdk5420.c
>> > +++ b/board/samsung/smdk5420/smdk5420.c
>> > @@ -43,98 +43,30 @@ int exynos_init(void)
>> > }
>> >
>> > #ifdef CONFIG_LCD
>> > -void cfg_lcd_gpio(void)
>> > +void exynos_cfg_lcd_gpio(void)
>> > {
>> > - struct exynos5_gpio_part1 *gpio1 =
>> > - (struct exynos5_gpio_part1
>> > *)samsung_get_base_gpio_part1();
>> > -
>> > - /* For Backlight */
>> > - s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
>> > - s5p_gpio_set_value(&gpio1->b2, 0, 1);
>> > -
>> > - /* LCD power on */
>> > - s5p_gpio_cfg_pin(&gpio1->x1, 5, GPIO_OUTPUT);
>> > - s5p_gpio_set_value(&gpio1->x1, 5, 1);
>> > + struct exynos5420_gpio_part2 *gpio2 =
>> > + (struct exynos5420_gpio_part2
>> > *)samsung_get_base_gpio_part2();
>> >
>> > /* Set Hotplug detect for DP */
>> > - s5p_gpio_cfg_pin(&gpio1->x0, 7, GPIO_FUNC(0x3));
>> > + s5p_gpio_cfg_pin(&gpio2->x0, 7, GPIO_FUNC(0x3));
>> > }
>> >
>> > -vidinfo_t panel_info = {
>> > - .vl_freq = 60,
>> > - .vl_col = 2560,
>> > - .vl_row = 1600,
>> > - .vl_width = 2560,
>> > - .vl_height = 1600,
>> > - .vl_clkp = CONFIG_SYS_LOW,
>> > - .vl_hsp = CONFIG_SYS_LOW,
>> > - .vl_vsp = CONFIG_SYS_LOW,
>> > - .vl_dp = CONFIG_SYS_LOW,
>> > - .vl_bpix = 4, /* LCD_BPP = 2^4, for output conosle on
>> > LCD */
>> > -
>> > - /* wDP panel timing infomation */
>> > - .vl_hspw = 32,
>> > - .vl_hbpd = 80,
>> > - .vl_hfpd = 48,
>> > -
>> > - .vl_vspw = 6,
>> > - .vl_vbpd = 37,
>> > - .vl_vfpd = 3,
>> > - .vl_cmd_allow_len = 0xf,
>> > -
>> > - .win_id = 3,
>> > - .cfg_gpio = cfg_lcd_gpio,
>> > - .backlight_on = NULL,
>> > - .lcd_power_on = NULL,
>> > - .reset_lcd = NULL,
>> > - .dual_lcd_enabled = 0,
>> > -
>> > - .init_delay = 0,
>> > - .power_on_delay = 0,
>> > - .reset_delay = 0,
>> > - .interface_mode = FIMD_RGB_INTERFACE,
>> > - .dp_enabled = 1,
>> > -};
>> > -
>> > -static struct edp_device_info edp_info = {
>> > - .disp_info = {
>> > - .h_res = 2560,
>> > - .h_sync_width = 32,
>> > - .h_back_porch = 80,
>> > - .h_front_porch = 48,
>> > - .v_res = 1600,
>> > - .v_sync_width = 6,
>> > - .v_back_porch = 37,
>> > - .v_front_porch = 3,
>> > - .v_sync_rate = 60,
>> > - },
>> > - .lt_info = {
>> > - .lt_status = DP_LT_NONE,
>> > - },
>> > - .video_info = {
>> > - .master_mode = 0,
>> > - .bist_mode = DP_DISABLE,
>> > - .bist_pattern = NO_PATTERN,
>> > - .h_sync_polarity = 0,
>> > - .v_sync_polarity = 0,
>> > - .interlaced = 0,
>> > - .color_space = COLOR_RGB,
>> > - .dynamic_range = VESA,
>> > - .ycbcr_coeff = COLOR_YCBCR601,
>> > - .color_depth = COLOR_8,
>> > - },
>> > -};
>> > -
>> > -static struct exynos_dp_platform_data dp_platform_data = {
>> > - .phy_enable = set_dp_phy_ctrl,
>> > - .edp_dev_info = &edp_info,
>> > -};
>> > -
>> > -void init_panel_info(vidinfo_t *vid)
>> > +void exynos_backlight_on(unsigned int onoff)
>> > {
>> > - vid->rgb_mode = MODE_RGB_P,
>> > + struct exynos5420_gpio_part1 *gpio1 =
>> > + (struct exynos5420_gpio_part1
>> > *)samsung_get_base_gpio_part1();
>> > +
>> > + struct exynos5420_gpio_part2 *gpio2 =
>> > + (struct exynos5420_gpio_part2
>> > *)samsung_get_base_gpio_part2();
>> > +
>> > + /* For PWM */
>> > + s5p_gpio_cfg_pin(&gpio1->b2, 0, GPIO_OUTPUT);
>> > + s5p_gpio_set_value(&gpio1->b2, 0, 1);
>>
>> Can we use generic GPIO calls instead? gpio_set_value(), etc
>
> I think GPIO numbering for exynos is yet to go in.
> Should wait till that goes in.
What is the hold-up on this? It was posted a very long time ago.
Regards,
Simon
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
