On 09/04/2013 07:00 AM, Alban Bedel wrote:
> Add support for the new Tamonten™ NG platform from Avionic Design.
> Currently only I2C, MMC, USB and ethernet have been tested.
(Also CC'ing the Tegra maintainer here)
> diff --git a/board/avionic-design/common/tamonten-ng.c
> b/board/avionic-design/common/tamonten-ng.c
> +void pmu_write(uchar reg, uchar data) +{ + int i; +
> i2c_set_bus_num(0); /* PMU is on bus 0 */ + for (i = 0; i <
> MAX_I2C_RETRY; ++i) { + if (i2c_write(PMU_I2C_ADDRESS, reg, 1,
> &data, 1)) + udelay(100); + else +
> break; + } +}
Is there really a need to retry the I2C transactions? If so, why do
they fail? I assume this was just copy/pasted from some other board
file, and there's no need for any retries?
It'd be nice if there was a proper PMU subsystem, so we could have a
specific driver for each PMU chip, rather than having
open-coded/custom writes to the PMU registers in each board file, but
I guess that's not an issue with this patch specfically.
> diff --git a/include/configs/tec-ng.h b/include/configs/tec-ng.h
> +/* support the new (FDT-based) image format */ +#define
> CONFIG_FIT
Hmmm. Do the standard Tegra boot scripts in tegra-common-post.h deal
well with FIT? I've tried to avoid FIT usage as much as possible.
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
