On 08/28/2013 01:03 PM, Marek Vasut wrote:
Dear Przemyslaw Marczak,
On 08/28/2013 10:44 AM, Marek Vasut wrote:
You still use dev_num further in the code, why not convert the whole
thing to use *mmc ?
Best regards,
Marek Vasut.
Hello,
I don't know exactly what do you mean.
I suppose that putting "mmc device number" as a parameter is easy to
maintain at command code and also intuitive to use at prompt.
Do you prefer set mmc dev number by command "mmc dev <num>" ?
Should we depends one command on another? If yes, then what about e.g.
fat or ext command set?
What I mean is ... for example, you pass dev_num to board_ums_init() . See the
trats board, find_mmc_device() is called again in there. Why not just pass the
*mmc directly?
Best regards,
Marek Vasut.
Oh, now I see. You are absolutely right, it was just code duplication.
I will change it and resend patch.
Thank you,
--
Przemyslaw Marczak
Samsung R&D Institute Poland
Samsung Electronics
p.marc...@samsung.com
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
