I would agree with the idea moving pl310 functionality into pl310-specific files - armv7 doesn't dictate use of pl310 (or an external cache controller of any nature) at least for about half the possible cores you could go find. Those that need/configure for an external L2 controller may not even really use pl310 (Marvell for example?) even if they're compatible with v7 in nature, so it makes no sense to just lump all the prototypes into a generic header.
Obviously it depends on what those functions are and if they're actually implemented elsewhere... in which case they should be moved to the pl310 support so they're not compiled in or needlessly cluttering up other source files. -- Matt On Mon, Aug 19, 2013 at 3:04 AM, <tiger...@viatech.com.cn> wrote: > Hi, experts: > > There are 4 functions definition in arch/arm/include/asm/pl310.h . > > But not implemented in cache-pl310.c file. > > > > And the implemented functions in cache-pl310.c file are defined in > arch/arm/include/asm/armv7.h . > > > > So, maybe pl310.h should be deleted? > > Or function declarations are moved from armv7.h to pl310.h ? > > > > Best wishes, > > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
