> -----Original Message----- > From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagn...@jcrosoft.com] > Sent: Saturday, April 04, 2009 9:55 PM > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Ronen Shitrit; Nicolas Pitre > Subject: Re: [U-Boot] [PATCH] Marvell Kirkwood family SOC support > > Hi, > > I'll provide you two seperate comment one for the file > location and global comment and an other for code review > > On 04:09 Sat 04 Apr , Prafulla Wadaskar wrote: > > From: prafulla_wadaskar <prafu...@marvell.com> > > > > Kirkwood family controllers are highly integrated SOCs based on > > Feroceon-88FR131/Sheeva-88SV131 cpu core. > > > > SOC versions supported:- > > 1) 88F6281-Z0 define CONFIG_KW88F6281_Z0 > > 2) 88F6281-A0 define CONFIG_KW88F6281_A0 > > 3) 88F6192-A0 define CONFIG_KW88F6192_A0 > > > > Other supported features:- > > 1) Doimage utility needed to create binaries with > > bootROM header > > 2) get_random_hex() fucntion > > 3) SPI port controller driver > > 4) PCI Express port initialization > > > > Contributors: > > Yotam Admon <yo...@marvell.com> > > Michael Blostein <michae...@marvell.com > > > > Signed-off-by: prafulla_wadaskar <prafu...@marvell.com> > Reviewed by: > > Ronen Shitrit <rshit...@marvell.com> > > --- > > board/Marvell/common/kw_lowlevel_init.S | 45 + > is this init are Marvell common or Kirkwood common? This is Marvell common, this is board specific but since it is used for each supported board I have moved it to common folder. > > board/Marvell/include/core.h | 4 + > > cpu/arm926ejs/kirkwood/Makefile | 52 + > > cpu/arm926ejs/kirkwood/bin_dep.sh | 50 + > what it this file? This was supported file to build doImage form tools context Removed..
> > cpu/arm926ejs/kirkwood/config.mk | 25 + > > cpu/arm926ejs/kirkwood/doimage/Makefile | 112 ++ > tools must go to tools/ Removed.. > > cpu/arm926ejs/kirkwood/doimage/bootstrap_def.h | 88 ++ > > cpu/arm926ejs/kirkwood/doimage/doimage | Bin 0 -> > 17712 bytes > please remove and a .gitignore entry for it Removed.. > > cpu/arm926ejs/kirkwood/doimage/doimage.c | 1341 > ++++++++++++++++++++++++ > > cpu/arm926ejs/kirkwood/dram.c | 49 + > > cpu/arm926ejs/kirkwood/kw88f6192.h | 34 + > please move define to include/asm-arm/arch-<somthing> the > same as linux Moved... > > cpu/arm926ejs/kirkwood/kw88f6281.h | 34 + > > cpu/arm926ejs/kirkwood/kwcore.c | 262 +++++ > > cpu/arm926ejs/kirkwood/kwcore.h | 141 +++ > > cpu/arm926ejs/kirkwood/serial.c | 187 ++++ > please move to drivers/serial/ Moved... > > cpu/arm926ejs/kirkwood/soc_init.S | 156 +++ > please call it lowlevel_init.S Renamed.. > > cpu/arm926ejs/kirkwood/spi.c | 213 ++++ > please move to drivers/spi/ Moved... > > cpu/arm926ejs/kirkwood/timer.c | 165 +++ > > include/configs/kirkwood.h | 46 + > include/configs/ are only for boards config Moved this file to asm-arm/arch-kirkwood/ I am in process accumulating and testing changes I will send you updated patch (v2) for the same Thanks.... Regards.. Prafulla . . > > Best Regards, > J. > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
