Dear Marek Vasut,
In message <1373710940-15779-1-git-send-email-ma...@denx.de> you wrote:
> Fix the following warning:
>
> mpc8323erdb.c: In function 'mac_read_from_eeprom':
> mpc8323erdb.c:198:3: warning: dereferencing type-punned pointer will break
> strict-aliasing rules [-Wstrict-aliasing]
> if (crc32(crc, buf, 24) == *(unsigned int *)&buf[24]) {
> ^
>
> Size remains unchanged after and before fix:
>
> text data bss dec hex filename
> 206977 18748 23344 249069 3cced ./u-boot
>
> Note the fix is the crudest possible, but also least intrusive.
Please see Timur's review comments to my original patch for this
isssue ([1]). The "unsigned int" should indeed be fixed.
I resubmitted a v2 with the review comments incorporated on July 08,
see [2], but I caught only one part of the needed changes. V3 sent
right now; see [3]. I'd rather see this added than yours.
Also note that it might be a good idea to add the MPC83xx custodion to
the Cc: list of such patches...
[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/163386
[2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/165266
[3] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/165731
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
You got to learn three things. What's real, what's not real, and
what's the difference." - Terry Pratchett, _Witches Abroad_
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
